FuhQuake Forum Index FuhQuake
https://fuhquake.net
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Bug: cfg_save does never save aliases (and a fix for that :)

 
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    FuhQuake Forum Index -> Bug Reports
View previous topic :: View next topic  
Author Message
Massa



Joined: 19 Sep 2002
Posts: 196
Location: Germany

PostPosted: Thu Oct 09, 2003 8:22 pm    Post subject: Bug: cfg_save does never save aliases (and a fix for that :) Reply with quote

normally if cfg_save_aliases is set to 1 the command cfg_save should also save all aliases to the given file.

But there are errors in config_manager.c which prevent it from doing.
The bug exists since v0.30Build 570 and is still in build 585.

Fuh, you wrote on several lines in config_manager.c:
Code:
if (!(a->flags & ALIAS_SERVER|ALIAS_TEMP))


This will always be true, because ALIAS_TEMP is always > 0 Wink

it should read like this:
Code:
if (!(a->flags & (ALIAS_SERVER|ALIAS_TEMP)))
Back to top
View user's profile Send private message
fuh
Almighty King


Joined: 07 Sep 2002
Posts: 2086

PostPosted: Fri Oct 10, 2003 2:01 am    Post subject: Reply with quote

This bug was fixed in build 585 (see the changelog). Looks to me like you are looking at the config_manager.c from 570. I have the one from 585 open in front of me and its fixed.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Massa



Joined: 19 Sep 2002
Posts: 196
Location: Germany

PostPosted: Fri Oct 10, 2003 5:07 am    Post subject: Reply with quote

Well, in that case the patch which you sent me was not complete Wink

I'll try to download the complete sources of 585 again...
Back to top
View user's profile Send private message
fuh
Almighty King


Joined: 07 Sep 2002
Posts: 2086

PostPosted: Fri Oct 10, 2003 1:12 pm    Post subject: Reply with quote

hmm yes, thats because I reuploaded the b570 sources with the fix as soon as I discovered the bug (few people on IRC asked me too). It's the only thing that would be missing from the patch.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
SyS



Joined: 26 Nov 2002
Posts: 36
Location: Hungary

PostPosted: Sun Oct 12, 2003 12:15 am    Post subject: Reply with quote

Massa!
i used cfg_save sys with the fuh 0.30-MM
in my sys.cfg: //no aliases
sux Crying or Very sad
_________________
SyS
Back to top
View user's profile Send private message
Massa



Joined: 19 Sep 2002
Posts: 196
Location: Germany

PostPosted: Sun Oct 12, 2003 5:21 am    Post subject: Reply with quote

Sorry for that!

A fixed version is now available for download...
Back to top
View user's profile Send private message
Display posts from previous:   
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    FuhQuake Forum Index -> Bug Reports All times are GMT + 10 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group

hosted by ausgamers